Skip to content

v1.3.1 #92

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 14 commits into from
Apr 13, 2017
Merged

v1.3.1 #92

merged 14 commits into from
Apr 13, 2017

Conversation

jaredcnance
Copy link
Contributor

Closes #85
Closes #86

jaredcnance added 13 commits April 7, 2017 09:05
@jaredcnance
feat(dasherized-route-conv): check if controller is JsonApiController
2878aac
@jaredcnance
chore(csproj): bump package version
f9564f5
@jaredcnance
test(acceptance): can use non json-api controllers
751f768
@jaredcnance
style
64c9723
@jaredcnance
Merge pull request #88 from Research-Institute/feat/allow-non-dasheri…
c4b3361 
…zed-routes

Feat/allow non dasherized routes
@jaredcnance
test(acceptance): failing test for related attr filter
9089bbd
@jaredcnance
feat(filter-query): add RelatedAttrFilterQuery for relational filters
1cc467d
@jaredcnance
feat(IQueryableExt): allow for filtering on attribute of included rel
87ec1a6
@jaredcnance
feat(default-entity-repository): use new filter extension
301bb43
@jaredcnance
test(attr-filter-tests): fix deserialization method
7a86cb4
@jaredcnance
chore(csproj): bump package version
5ade61a
@jaredcnance
Merge pull request #90 from Research-Institute/feat/filter-on-rel-attrs
e37d4a3 
Feat/filter on rel attrs
@jaredcnance
chore(csproj): downgrade package version
8a07949
JanMattner
JanMattner suggested changes Apr 12, 2017
View reviewed changes
Copy link
Contributor

@JanMattner JanMattner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With this solution it is only possible to have a JSONAPI controller with dasherized route that directly inherits from the base class JsonApiController. However, it should be possible to have a deeper inheritance hierarchy.

@JanMattner
Copy link
Contributor

JanMattner commented Apr 12, 2017 •
edited
Loading

I have added tests for the deeper inheritance case and fixed it with a simpler check for the subtype. I think that should be sufficient.

@jaredcnance are you okay with that? Apart from that, I think everything else is fine.

@jaredcnance
Copy link
Contributor Author

@JanMattner looks great! Thanks!

I want to let this sit for another day or so to give anyone else a chance to comment before merging this in. Until then, these changes are available on MyGet.

@jaredcnance jaredcnance merged commit 219ccfc into master Apr 13, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JanMattner JanMattner JanMattner requested changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jaredcnance @JanMattner